-
Notifications
You must be signed in to change notification settings - Fork 721
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for Tuya MMW sensors: _TZE204_qasjif9e
, _TZE204_sxm7l9xa
, _TZE204_e5m9c5hl
#2525
base: dev
Are you sure you want to change the base?
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## dev #2525 +/- ##
==========================================
+ Coverage 87.35% 87.41% +0.05%
==========================================
Files 287 287
Lines 8835 8875 +40
==========================================
+ Hits 7718 7758 +40
Misses 1117 1117 ☔ View full report in Codecov by Sentry. |
Address flagged issue in build pipeline
Address formatting flagged in build pipeline
for dp_convert
fix formatting
How to add unittests and what kind of unittests? Or how to grt this merged? |
This example code does not support |
it supports but there are limitations. |
Yes, the lux is working. I tried to get the target distance working. But did not see what was missing. @evgenln if you have any pointers, i can have a look in an other pr. |
Add support for TZE204_sxm7l9xa
fix tailing whitespaces
add missing enter
fix showing lux for _TZE204_sxm7l9xa
Merged the changes from this pr @arbrandes: into this pr, it now does _TZE204_sxm7l9xa |
fix the white spaces
It seems I broke the _TZE204_qasjif9e, I'll update when I have a fix |
fixed _TZE204_qasjif9e but lost lux on _TZE204_sxm7l9xa
It seems latest version both sensors work correctly for presence and lux |
I recently got a _TZE204_qasjif9e mmWave motion sensor and was trying to set it up. Can I assist in testing at all? I'm an amateur and coding so may not be able to help there, but willing to test and report back if I can help. The device was introduced to the ZHA network as normal and appears, just no useful entities or functions. |
You can test the file from the PR: Create a custom quirk dir in HA, e.g., /config/custom_zha_quirks |
Hello, I recently purchased two mmWave modules (_TZE204_qasjif9e and _TZE204_sxm7l9xa). With the latest change of ts0601_motion.py in the path /config/custom_zha_quirks/ I managed to configure correctly with ZHA. I can already see the entities. If there is any test I would be happy to do. |
This is working great for me! Thank you for all your efforts with this. |
@TheJulianJES what are the steps to get this merged? |
@SavoryLikeBacon - So you've tried this with qasjif9e and it's not working? |
@Coysh @SavoryLikeBacon Can you use this older version of the quirk: This version is working, the current version is not working because we try to make some breaking changes that have to go on myltiple places. |
Confirmed working. I have a _TZE204_e5m9c5hl and can see the controls and occupency sensor in HA. |
Yep - this one is working for me, see attached: Not sure if it should be logging the history of the controls though, but I'm not experienced in these things. |
So I just received a new mmwave sensor TS0601 by _TZE204_muvkrjr5 from Aliexpress. I am new to all this. I thougth integration would be straight, but I guess I need a quirk file to make parameters available in Home Assistant :( Can someone help? |
INFO (MainThread) [zigpy.endpoint] [0xb905:1] Discovered endpoint information: SizePrefixedSimpleDescriptor(endpoint=1, profile=260, device_type=81, device_version=1, input_clusters=[4, 5, 61184, 0], output_clusters=[25, 10]) |
does yours report motion/presence/illuminance and detected distance? i have TZE204_qasjif9e but I can't seem to get anything to work other than the presence and illum and thats using https://fixtse.com/blog/zy-m100-full-zha-support , I can't get any of them to work from ones i've found in here or other places on github :-| |
just to add/clarify, I'm have used the py code above, replaced the signature to reflect my model but it never seems to pick up on this quirk, restarted ha and re-paired the sensor but still nothing. just picks up default quirk. I'm unsure why. nothing is in logs saying it can't parse it. it should at least pick it up and use it even if it doesnt work |
|
yes thats what i'm saying, it wasn't loaded; it is using the default quirk still |
And I think you should delete the pycache folder, so HA can rebuild it with new quirk. |
yes, all those aspects are fine. i'm using other quirks for other devices. and using a different quirk for this device works, just this quirk doesnt and i REALLY need the target distance aspect to work, and i didnt know i could get the temp from it too |
to be clear, I changed
and replaced with
and copied it as is. so I don't see how i could have typo'd |
i'm sure it is something to do with the code so that it isn't just that line of the py file signature that causes HA to associate the quirk with it. |
In case it is useful, I can confirm this version works for me too for _TZE204_e5m9c5hl. Awesome, thanks! I hope this PR is sorted out soon and the support is merged. |
This version worked for me with following
|
It would be great if these Tuya MMW Sensors would have native support in ZHA and no custom quirk was needed. Is there any reason this quirk is not incorporated in ZHA? What's holding it back? |
mainly because Tuya don't adhere to the Zigbee standard. |
Documentation isn't quite ready yet, but all "fake" |
I do not think those are the same, just replacing the signature will not get it to work. You have to do the mapping for the yensya2c to get it to work. |
What is status for this PR? |
I have moved to zigbee2mqtt for these devices. After there was issue in HA where these devices took down my network (ZHA) plus the time it takes to get all requirements to make this ready for merging, I have spend my time re-pairing my devices once to MQTT and the work fine. |
anyone got a better quirk for these devices yet? |
Proposed change
Add support for Tuya MMW sensor _TZE204_qasjif9e and _TZE204_sxm7l9xa
Additional information
Added support based on example code in #2378 (comment)
#2510
Checklist
pre-commit
checks pass / the code has been formatted using Black